Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

588 adding stratified newcombe@main #696

Merged
merged 60 commits into from
Sep 12, 2022
Merged

588 adding stratified newcombe@main #696

merged 60 commits into from
Sep 12, 2022

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Sep 6, 2022 •
edited
Loading

Pull Request

Fixes #588

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022 •
edited
Loading

Unit Tests Summary

       1 files     115 suites   4m 47s ⏱️
   790 tests    790 ✔️ 0 💤 0 ❌
1 191 runs  1 191 ✔️ 0 💤 0 ❌

Results for commit a4001fd.

♻️ This comment has been updated with latest results.

@danielinteractive danielinteractive self-assigned this Sep 7, 2022
danielinteractive
danielinteractive reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @Melkiades , good start! please see inside

R/estimate_proportion.R Show resolved Hide resolved
R/estimate_proportion.R Outdated Show resolved Hide resolved
R/estimate_proportion.R Show resolved Hide resolved
R/estimate_proportion.R Outdated Show resolved Hide resolved
R/estimate_proportion.R Outdated Show resolved Hide resolved
R/estimate_proportion.R Outdated Show resolved Hide resolved
R/estimate_proportion.R Outdated Show resolved Hide resolved
R/estimate_proportion.R Outdated Show resolved Hide resolved
tests/testthat/test-estimate_proportion.R Outdated Show resolved Hide resolved
tests/testthat/test-estimate_proportion.R Show resolved Hide resolved
@Melkiades Melkiades mentioned this pull request Sep 7, 2022
Closed
@danielinteractive
Copy link
Contributor

@Melkiades please request re-review once ready, thanks

@Melkiades
Copy link
Contributor Author

@Melkiades please request re-review once ready, thanks

I am just not sure about the missing(.var) alternative. I need to find a case in which this breaks. ATM, there is a test_atomic_vector(df) in place. I am also working on adding Rdpack, if @cicdguy is fine with it, but it will be another issue

danielinteractive
danielinteractive approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Melkiades , this looks much better, good to merge after resolving the last inside comments. Good then to follow up with 1) SAS comparison, 2) we need to expose this option especially the stratified Newcombe CI in teal.modules.clinical, 3) (less time sensitive) is the Rdpack thing.

R/estimate_proportion.R Show resolved Hide resolved
R/prop_diff.R Outdated Show resolved Hide resolved
tests/testthat/test-estimate_proportion.R Outdated Show resolved Hide resolved
@Melkiades Melkiades mentioned this pull request Sep 12, 2022
Closed
@Melkiades Melkiades enabled auto-merge (squash) September 12, 2022 09:42
@Melkiades Melkiades mentioned this pull request Sep 12, 2022
Closed
@Melkiades Melkiades merged commit 2ffaede into main Sep 12, 2022
@Melkiades Melkiades deleted the 588_adding_stratified_newcombe@main branch September 12, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdguy cicdguy cicdguy left review comments

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees

@danielinteractive danielinteractive

Labels
priority sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prop_diff_stratnc() calculating the stratified Newcombe CI
3 participants
@Melkiades @danielinteractive @cicdguy