-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
759 document formats@main #795
Conversation
Merge branch 'main' into 759_document_formats@main
Code Coverage Summary
Diff against main
Results for commit: 6f6b6ce Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Hi @Nolan-Steed, I made a bunch of updates to your vignette (grammar, added more examples, etc.) - feel free to re-review the vignette and revert any changes/let me know if you have any questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @edelarua for all of your help with this. Your additions look great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nolan-Steed looks good to me! I think we've covered the basics, but if we think of anything else to add that can be done later in another PR.
FANTASTIC! Thank you so much guys! @Nolan-Steed @edelarua |
Fixes #759