-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing g_forest for older versions of testthat #803
Conversation
Code Coverage Summary
Diff against main
Results for commit: 64be904 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Why did we have to update the snapshots? is it due to a change in std formats? |
I think due to a change in default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Should be good to merge now @Melkiades
Fixes #802
I cannot reproduce yet the other warnings (
vec_unchop()
is not used bytern
, norggplot2::element_rect()
usessize
as a parameter). I will try also on bee, but in the meantime maybe also @edelarua can take a look ;)