-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data labels, fix footnote function warnings #835
Conversation
Code Coverage Summary
Diff against main
Results for commit: a3b5757 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Additional test case details
Results for commit a3b5757 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thank you for solving the deprecation of footnotes, I forgot to add it to pkgdown's section. Well done with the relabelling too!! I think it is better now for clarity of examples and tests. I am not sure about adding them one by one as you did for tmc for the moment I just copy them in from scda. Eventually, I will do as you do ;)
Closes #834