-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added var_labels argument #853
Conversation
Code Coverage Summary
Diff against main
Results for commit: d5d36fb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @Nolan-Steed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Nolan-Steed , can you check if the tests need to be updated as well please. thanks
…ghtsengineering/tern into 852_test_proportion_diff_label@main Pulling changes
Hey @shajoezhu all of the tests still passed. I added the variable label to a couple of the tests that existed to make sure that no warnings or errors occur with this added to the |
Fixes #852