-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check tests after formatters' changes #912
Merged
Melkiades
merged 7 commits into
main
from
903_check_tests@96_exporter_pagination_migration
May 18, 2023
Merged
Check tests after formatters' changes #912
Melkiades
merged 7 commits into
main
from
903_check_tests@96_exporter_pagination_migration
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Diff against main
Results for commit: 9eb8704 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
10 tasks
Melkiades
commented
May 17, 2023
Signed-off-by: Davide Garolini <[email protected]>
shajoezhu
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @Melkiades
shajoezhu
added a commit
that referenced
this pull request
May 23, 2023
Blocked by: - [x] #912 - [x] insightsengineering/formatters#149 - [x] insightsengineering/rtables#636 Closes #920 --------- Signed-off-by: Emily de la Rua <[email protected]> Signed-off-by: Joe Zhu <[email protected]> Co-authored-by: Joe Zhu <[email protected]> Co-authored-by: shajoezhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903