Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PKCT01 #104

Merged
merged 17 commits into from
Sep 8, 2023
Merged

Refactor PKCT01 #104

merged 17 commits into from
Sep 8, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Aug 30, 2023 •
edited
Loading

@edelarua edelarua added the sme label Aug 30, 2023
@edelarua edelarua marked this pull request as ready for review August 31, 2023 01:17
@shajoezhu
Copy link
Contributor

hi @qiliu1013 , can you please help to review this template snapshot. Thanks!

https://github.com/insightsengineering/tlg-catalog/blob/f6d52f02de44de5c34351ac54d9da8bd6ba0637f/package/tests/testthat/_snaps/pkct01/markdown-snaps.md

Melkiades
Melkiades reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error that looks unrelated:

  Quitting from lines 45-118 [variant1] (adat03.qmd)
  Error:
  ! Error in content (summary) function: unused argument (cache_env = <environment>)
  	occured at path: ARM[A: Drug X]

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

Unit Tests Summary

    1 files  2 suites   1m 32s ⏱️
  26 tests 0 ✔️   26 💤 0 ❌
277 runs  0 ✔️ 277 💤 0 ❌

Results for commit 36e6d2f.

♻️ This comment has been updated with latest results.

Melkiades
Melkiades approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Emily! It is very good :)

anajens
anajens reviewed Sep 8, 2023
View reviewed changes
package/tests/testthat/_snaps/pkct01/markdown-snaps.md Outdated
——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————
A: Drug X (N=134)
Day 1
0 134 134 0 0 NE 0 NE 0 0 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edelarua not sure that the 0 should display here for geometric mean?

Per GDSR:
image

anajens
anajens approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@anajens anajens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@edelarua edelarua merged commit aadb54c into main Sep 8, 2023
13 checks passed
@edelarua edelarua deleted the 277_refactor_pkct01@main branch September 8, 2023 19:11
@edelarua edelarua removed the blocked label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiliu1013 qiliu1013 qiliu1013 left review comments

@Melkiades Melkiades Melkiades approved these changes

@anajens anajens anajens approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edelarua @shajoezhu @Melkiades @qiliu1013 @anajens