Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra #49

Merged
merged 13 commits into from
Jun 25, 2024
Merged

Add extra #49

merged 13 commits into from
Jun 25, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jun 20, 2024

No description provided.

@pawelru pawelru marked this pull request as ready for review June 21, 2024 08:59
Copy link
Contributor

github-actions bot commented Jun 21, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-280
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         239     238  0.42%    13-473, 492-535
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            66      42  36.36%   3-23, 41, 47, 57-104
TOTAL                               701     623  11.13%

Diff against main

Filename                          Stmts    Miss  Cover
------------------------------  -------  ------  --------
R/deps_installation_proposal.R       +4      +4  +100.00%
R/desc_utils.R                      +25       0  +15.77%
TOTAL                               +29      +4  +3.24%

Results for commit: 994e0de

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Unit Tests Summary

 1 files   4 suites   1s ⏱️
43 tests 15 ✅ 28 💤 0 ❌
96 runs  67 ✅ 29 💤 0 ❌

Results for commit 994e0de.

♻️ This comment has been updated with latest results.

@pawelru pawelru linked an issue Jun 21, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is similar to what I had in mind 💯

I think we should create a safeguard to prevent manipulation of direct dependencies.

We can't protect against all malicious use, but this is an easy one in my opinion.

R/desc_utils.R Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
desc_utils 👶 $+0.02$ desc_add_extra_deps_raises_error_for_already_existing_package
desc_utils 👶 $+0.01$ desc_add_extra_deps_will_add_extra_dependencies

Results for commit 54b385d

♻️ This comment has been updated with latest results.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@pawelru pawelru merged commit f346850 into main Jun 25, 2024
30 checks passed
@pawelru pawelru deleted the add_extra branch June 25, 2024 11:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add hint to install indirect dependency on a newer snapshot
2 participants