Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an error was being raised as pointed at #12 even if one follow … #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed an error was being raised as pointed at #12 even if one follow … #14

wants to merge 2 commits into from

Commits on Jan 7, 2016

  1. Fixed an error was being raised as pointed at insin#12 even if one fo… 

    …llow the docs:

    Warning: Failed propType: Required prop `form` was not specified in `BootstrapForm`. Check the render method of `App`.

As far as I see the `required` of form is only used in order to guarantee it is used between a newforms.Form tag. But if you don`t pass it, an error is raised anyway:
   Uncaught TypeError: Cannot read property `__patchedByBootstrapForm` of undefined

So I removed the mandatory form and made a validation inside render.
    Ivens Rocha committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    b40d543 View commit details
    Browse the repository at this point in the history

  2. Fixed an error was being raised as pointed at insin#12 even if one fo… 

    …llow the docs:

    Warning: Failed propType: Required prop `form` was not specified in `BootstrapForm`. Check the render method of `App`.

As far as I see the `required` of form is only used in order to guarantee it is used between a newforms.Form tag. But if you don`t pass it, an error is raised anyway:
   Uncaught TypeError: Cannot read property `__patchedByBootstrapForm` of undefined

So I removed the the "required" form property on propTypes and made a validation inside render.
    Ivens Rocha committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    ba907a7 View commit details
    Browse the repository at this point in the history