Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Dark mode #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/Dark mode #60

wants to merge 4 commits into from

Conversation

vb
Copy link

@vb vb commented Jul 14, 2016

Added dark mode to settings panel #54

  • The value is stored both in the state and in local storage for storage and faster rendering.
  • I picked the colors from @insin design in the issue
  • My initial idea was to toggle a html class and use currentColor css value inheritance. But since that breaks the encapsulation (and it was way harder to use currentColor than I thought) I skipped that. There is a component in 24771e7 if anyone is interested.

@insin
Copy link
Owner

insin commented Jul 14, 2016

Thanks for the PR, I like having a single dark mode toggle in place - removes the temptation I was feeling to go all YAGNI while adding a single new theme 👍

I think some of the highlighting stuff I was playing about with in the example screenshot needed some content changes to support getting the blue highlights in the right place - will check when I'm back at the machine I did that on.

@catskull
Copy link

Can we get this merged sooner than later? Literally the only thing keeping me from.using this exclusively.

@addyosmani
Copy link
Collaborator

Friendly ping @insin in case he has a chance to review (it seemed like there were content adjustments necessary for the right highlights) 🐐

@catskull
Copy link

Bueller...

@insin insin removed their assignment Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants