PLAT-671: send VDelegatedRequestFinished after retries for correct pending count #568
Conversation
aalekseev-ru
added
autoupdate
…671_send_VDelegatedRequestFinished_after_retries
| @@ -722,6 +722,8 @@ func (s *SMExecute) stepSendOutgoing(ctx smachine.ExecutionContext) smachine.Sta | |||
| } | |||
| } else { | |||
| if s.outgoingSentCounter >= MaxOutgoingSendCount { | |||
| // TODO when CallSummary will live longer than one pulse it needs to be updated | |||
| s.sendDelegatedRequestFinished(ctx, nil) | |||
There was a problem hiding this comment.
I don't like the idea of setting "sendDelegatedRequestFinished" in every place where work can be stopped prematurely :)
I'd prefer to set "ErrorHandler"/"some kind of destructors" somewhere and catch all that situations at once.
There was a problem hiding this comment.
We discuss this with @ruz and decided that this is important for pending tables. Or I can't understand your idea in second sentence.
There was a problem hiding this comment.
I mean that part of code (send pending request finished) must be executed on every exit scenario after we've received VDelegatedCallResponse
There was a problem hiding this comment.
But that's a big addition, so I guess only if @ruz is OK
There was a problem hiding this comment.
Yeah, we need some kind of destructor for this.
…of github.com:insolar/assured-ledger into PLAT-671_send_VDelegatedRequestFinished_after_retries
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=========================================
Coverage ? 61.77%
=========================================
Files ? 691
Lines ? 47068
Branches ? 0
=========================================
Hits ? 29075
Misses ? 15833
Partials ? 2160
Continue to review full report at Codecov.
|
aalekseev-ru
requested review from
AndreyBronin,
ivanshibitov,
MikhailZhukov and
ruz
insolar-bulldozer
bot
deleted the
PLAT-671_send_VDelegatedRequestFinished_after_retries
branch
add send, add log in handler for empty latestState case, actualize test