Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-406: VCallRequest fail with error if interference==intolerable and runner change state #569

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

MikhailZhukov
Copy link
Contributor

VCallRequest must fail with error if interference==intolerable and runner change object state

@MikhailZhukov MikhailZhukov added the autoupdate This branch will be automatically updated by the Bulldozer bot label Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #569 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   61.63%   61.70%   +0.06%     
==========================================
  Files         691      691              
  Lines       46981    46984       +3     
==========================================
+ Hits        28958    28990      +32     
+ Misses      15859    15840      -19     
+ Partials     2164     2154      -10     
Impacted Files Coverage Δ
ledger-core/virtual/execute/execute.go 81.80% <100.00%> (+0.08%) ⬆️
...e/network/consensus/serialization/packet_reader.go 72.67% <0.00%> (-1.56%) ⬇️
...ensus/gcpv2/phasebundle/announce/announce_utils.go 57.32% <0.00%> (-1.28%) ⬇️
...etwork/consensus/serialization/globula_protocol.go 52.73% <0.00%> (-0.69%) ⬇️
...twork/consensus/gcpv2/phasebundle/ph2ctl/phase2.go 70.31% <0.00%> (+0.45%) ⬆️
ledger-core/log/bpbuffer/backpressure_buffer.go 72.09% <0.00%> (+0.77%) ⬆️
ledger-core/log/adapters/bilog/adapter.go 65.89% <0.00%> (+0.92%) ⬆️
...-core/network/consensus/gcpv2/core/round_worker.go 62.43% <0.00%> (+1.05%) ⬆️
...er-core/network/consensus/gcpv2/core/realm_prep.go 61.23% <0.00%> (+1.12%) ⬆️
...rumentation/inslogger/instestlogger/test_helper.go 79.26% <0.00%> (+1.21%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9141aec...18335b4. Read the comment docs.

@MikhailZhukov MikhailZhukov force-pushed the PLAT-406_cheeck_interference_on_save_object branch from d46c16b to 0c63b7c Compare July 23, 2020 09:47
@MikhailZhukov MikhailZhukov force-pushed the PLAT-406_cheeck_interference_on_save_object branch from 0c63b7c to eb00de7 Compare July 23, 2020 09:59
@MikhailZhukov MikhailZhukov added the automerge PR is ready to be merged automatically label Jul 23, 2020
@insolar-bulldozer insolar-bulldozer bot merged commit 02d09c5 into master Jul 23, 2020
@insolar-bulldozer insolar-bulldozer bot deleted the PLAT-406_cheeck_interference_on_save_object branch July 23, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PR is ready to be merged automatically autoupdate This branch will be automatically updated by the Bulldozer bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants