-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE: fix_ci_runs_on_wrong_commit #573
NOISSUE: fix_ci_runs_on_wrong_commit #573
Conversation
Please, set the right name for PR and body of PR (it'll go to commit name and commit body respectively) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a solution. Running tests on a head
instead of merge
commit is no better than running it on any other wrong commit.
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 61.71% 61.75% +0.04%
==========================================
Files 691 691
Lines 46995 46995
==========================================
+ Hits 29001 29021 +20
+ Misses 15833 15812 -21
- Partials 2161 2162 +1
Continue to review full report at Codecov.
|
@aalekseev-ru, just a reminder: We separate words in branch names with hyphens, not underscores. |
we have a call and decided to discuss this with team, current solution has its own problems. The key to this problems hides in "head.sha" and "merge.sha" provided by github. @ita-sammann has few ideas how to solve it with side scrypts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that it's actually a good solution for us. Because we have a "require branch to be up to date" restriction on PRs.
try to fix problem, when GHA running not on the latest commit. It causes here
https://github.com/insolar/assured-ledger/pull/568/checks?check_run_id=901992719
look at commit hashes in "checkout code" job and in left up corner
discussion where i take this solution
actions/checkout#299
I never done this before, so i hope I do it right