Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE: fix_ci_runs_on_wrong_commit #573

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

aalekseev-ru
Copy link
Contributor

@aalekseev-ru aalekseev-ru commented Jul 24, 2020

try to fix problem, when GHA running not on the latest commit. It causes here
https://github.com/insolar/assured-ledger/pull/568/checks?check_run_id=901992719
look at commit hashes in "checkout code" job and in left up corner
image

discussion where i take this solution
actions/checkout#299

I never done this before, so i hope I do it right

@bigbes
Copy link
Contributor

bigbes commented Jul 24, 2020

Please, set the right name for PR and body of PR (it'll go to commit name and commit body respectively)

@ita-sammann ita-sammann self-assigned this Jul 24, 2020
Copy link
Contributor

@ita-sammann ita-sammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a solution. Running tests on a head instead of merge commit is no better than running it on any other wrong commit.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #573 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   61.71%   61.75%   +0.04%     
==========================================
  Files         691      691              
  Lines       46995    46995              
==========================================
+ Hits        29001    29021      +20     
+ Misses      15833    15812      -21     
- Partials     2161     2162       +1     
Impacted Files Coverage Δ
ledger-core/conveyor/smachine/slot_polling.go 83.67% <0.00%> (-6.13%) ⬇️
.../consensus/gcpv2/core/purgatory/realm_purgatory.go 74.04% <0.00%> (-3.82%) ⬇️
...twork/consensus/gcpv2/phasebundle/ph2ctl/phase2.go 68.94% <0.00%> (-2.29%) ⬇️
ledger-core/network/consensus/adapters/handlers.go 74.07% <0.00%> (-1.86%) ⬇️
ledger-core/network/utils.go 75.43% <0.00%> (-1.76%) ⬇️
ledger-core/ledger/server/lineage/line_staged.go 56.39% <0.00%> (-0.76%) ⬇️
...e/network/consensus/gcpv2/core/round_controller.go 68.00% <0.00%> (ø)
...-core/network/consensus/gcpv2/core/round_worker.go 62.43% <0.00%> (+1.05%) ⬆️
ledger-core/conveyor/smachine/context_basic.go 59.42% <0.00%> (+1.08%) ⬆️
...er-core/network/consensus/gcpv2/core/realm_prep.go 61.23% <0.00%> (+1.12%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7364d10...2ec41fa. Read the comment docs.

@ita-sammann
Copy link
Contributor

ita-sammann commented Jul 24, 2020

@aalekseev-ru, just a reminder: We separate words in branch names with hyphens, not underscores.

@aalekseev-ru aalekseev-ru added the autoupdate This branch will be automatically updated by the Bulldozer bot label Jul 24, 2020
@aalekseev-ru
Copy link
Contributor Author

we have a call and decided to discuss this with team, current solution has its own problems. The key to this problems hides in "head.sha" and "merge.sha" provided by github. @ita-sammann has few ideas how to solve it with side scrypts.

Copy link
Contributor

@ita-sammann ita-sammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that it's actually a good solution for us. Because we have a "require branch to be up to date" restriction on PRs.

@aalekseev-ru aalekseev-ru added the automerge PR is ready to be merged automatically label Jul 24, 2020
@aalekseev-ru aalekseev-ru changed the title NO_ISSUE fix_ci_runs_on_wrong_commit NOISSUE: fix_ci_runs_on_wrong_commit Jul 27, 2020
@insolar-bulldozer insolar-bulldozer bot merged commit ad806de into master Jul 27, 2020
@insolar-bulldozer insolar-bulldozer bot deleted the NO_ISSUE_fix_ci_runs_on_wrong_commit branch July 27, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PR is ready to be merged automatically autoupdate This branch will be automatically updated by the Bulldozer bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants