Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soumyo/aws_hosted_zone_all_record_issue_fix #811

Merged
merged 7 commits into from
Jan 3, 2022
Merged

soumyo/aws_hosted_zone_all_record_issue_fix #811

merged 7 commits into from
Jan 3, 2022

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Dec 14, 2021 •
edited
Loading

Signed-off-by: Soumyodeep Karmakar [email protected]

Description

By default aws route53 api returns 100 items in each response , when there are more than 100 records , pagination needs to handle. Now we have added the pagination.

Issues Resolved

#809

Check List

Please fill the box or appropriate ([x]) or mark N/A.

@soumyo13
issue fix
e559441 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13 soumyo13 self-assigned this Dec 14, 2021
@soumyo13 soumyo13 requested review from a team as code owners December 14, 2021 07:11
@soumyo13
fixed the unit tests
44130ab 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@soumyo13 soumyo13 linked an issue Dec 14, 2021 that may be closed by this pull request
aws_hosted_zone not reading all the records in route53 #809
Closed
Nirbhay1997
Nirbhay1997 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyo13
resolved conflicts
27a0e67 
Signed-off-by: Soumyodeep Karmakar <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 2300ca3 into main Jan 3, 2022
@soumyo13 soumyo13 deleted the soumyo/aws_hosted_zone_all_record_issue_fix branch January 3, 2022 05:26
@Nirbhay1997 Nirbhay1997 linked an issue Jan 10, 2022 that may be closed by this pull request
hosted_zone missing records #356
Closed
This was referenced Oct 20, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@Nirbhay1997 Nirbhay1997 Nirbhay1997 approved these changes

Assignees

@soumyo13 soumyo13

Labels
2021_PQ4 Bug Documentation ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_hosted_zone not reading all the records in route53 hosted_zone missing records
3 participants
@soumyo13 @IanMadd @Nirbhay1997