Sync fork #4
Merged
Sync fork #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the fixtures, so it is easier to add a flag to pytest to use an process started without the fixtures.
Adds CLI options to configure test fixtures for using external services. Previously this was done with environment variables, the advantage of the flags is that `pytest --help tests` will show the options, and that now there is a bit of validation to allow all test to run.
test_remote_client would leave a subject in a dirty state, if the test is ran twice in a row with the same kafka cluster it would fail.
test_subscription leaves the subscription group in a dirty state after the test finishes. When executing the tests against containerized servers this makes the second ran fail.
tests: fix parallel runs of test_subscription
…vice CLI options for external service
tests: allow repeated execution of test_remote_client
Fixes test_master_selection so that it can ran in parallel. For it to work properly random ports, group_ids, and client_ids are used to prevent conflicts.
When executing tests with a Kafka broker in a docker container it takes some additional time for the Rest/Registry servers to synchronize, that caused flakiness. The flakiness issues were fixed with a polling tool that waits until the new topic is seen.
when executing tests against container services it takes a bit more of time for the services to synchronize. This adds polling for APIs calls that would may fail on the first try because of these timming issues.
Fix test master selection and tests with timings issues for topics
30 seconds is not sufficient is some cases to run zookeeper and kafka on github workflows, this is causing flakiness: Here is an example of a flakiness: 2021-03-24T09:18:02.7723927Z tests/integration/test_client.py::test_remote_client[pyloop] 2021-03-24T09:18:02.7743108Z filelock MainThread INFO Lock 140042435949008 acquired 2021-03-24T09:18:20.8720742Z filelock MainThread INFO Lock 140401743256016 released ... 2021-03-24T09:18:32.7708050Z Timeout It took 18secs to start the servers, and the additional 12secs was not sufficient for the two karapace servers started by `registry_async_pair` to finish starting.
Sync kafka settings
tests: cosmetic change, consistently using new_random_name
tests: increase test timeout
Configuring the logging in the base class constructor interferes with the testing runner configuration, it effectively overwrites pytest's configuration making the flag `--log-cli-level` unusable.
it should be 40403 and not 40401
This removes the coupling from the backup test and the registry_async fixture, allowing the use of an external registry without breaking the test.
Early log level configuration
Fix tests backup
Otherwise the services will join the existing group and the tests may fail if the services started by the fixtures can not communicate with the external services.
…istry tests: dont run rest/registry if external services are used
rest: fix error code
Documentation for compatibility modes
Having the schemas in a separate file allows both unit and integration tests to use them.
this change is cosmetic, it is streamlining the unit tests for the jsonschema to make them regular and easier to scan trough
Jsonschema rest tests
It is possible to generate empty backup files, this should not be treated as an error.
…an-error schema_backup: do not treat empty files as an error #199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.