Modifies json_utils.pull_neptune_data to now download files concurrently #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Neptune logs are now downloaded concurrently yielding increased download speed. - We now only fetch the `sys/id` column when initialising the project instead of downloading the full table. - The downloaded JSON files are extracted directly into the `store_directory` creating a flat file structure. i.e. No more nested JSON files. - Downloaded files are also named according to their `run_id`.
|
|
RuanJohn
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
I have been using this for a while. Thanks for this @liamclarkza 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
sys/idcolumn when initialising the project instead of downloading the full table.store_directory, creating a flat file structure. i.e. No more nested folders.run_id.