Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored Go Tracer for Go version 1.23 #887

Merged
merged 2 commits into from
Aug 21, 2024
Merged

refactored Go Tracer for Go version 1.23 #887

merged 2 commits into from
Aug 21, 2024

Conversation

Angith
Copy link
Contributor

@Angith Angith commented Aug 21, 2024

  • Remove warnings in the build pipeline.
  • Test go-sensor SDK against Go 1.23

@Angith Angith self-assigned this Aug 21, 2024
@Angith Angith requested a review from a team as a code owner August 21, 2024 09:47
sanojsubran
sanojsubran approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@sanojsubran sanojsubran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @Angith

@nithinputhenveettil nithinputhenveettil added the tekton_ci Add this label to start running Tekton pipelines label Aug 21, 2024
@Angith Angith merged commit a61488e into main Aug 21, 2024
4 checks passed
@Angith Angith deleted the refactor-golang-1.23 branch August 21, 2024 12:08
nithinputhenveettil pushed a commit that referenced this pull request Aug 30, 2024
@Angith @nithinputhenveettil
refactored Go Tracer for Go version 1.23 (#887)
abe4866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanojsubran sanojsubran sanojsubran approved these changes

@nithinputhenveettil nithinputhenveettil Awaiting requested review from nithinputhenveettil

Assignees

@Angith Angith

Labels
ready for review tekton_ci Add this label to start running Tekton pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angith @sanojsubran @nithinputhenveettil