Skip to content

Commit

Permalink
feat(node-v21): added support for node v21
Browse files Browse the repository at this point in the history
  • Loading branch information
aryamohanan committed Nov 29, 2023
1 parent 33f6905 commit cf0d664
Show file tree
Hide file tree
Showing 46 changed files with 31 additions and 5 deletions.
26 changes: 25 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,29 @@ memcached: &memcached
- image: memcached:1.6.9

jobs:
"node-21":
docker:
- image: cimg/node:21.1
- <<: *zookeeper
- <<: *elasticsearch
- <<: *mongo
- <<: *redis
- <<: *kafka
- <<: *schema-registry
- <<: *mysql
- <<: *postgres
- <<: *mssql
- <<: *rabbitmq
- <<: *nats
- <<: *nats-streaming
- <<: *memcached
- <<: *couchbase
- <<: *couchbase-setup
- <<: *localstack
<<: *shared
parallelism: 15
resource_class: large

"node-20":
docker:
- image: cimg/node:20.3
Expand Down Expand Up @@ -461,7 +484,7 @@ workflows:
- not:
equal: [ scheduled_pipeline, << pipeline.trigger_source >> ]
jobs:
- "node-20"
- "node-21"

other-nodejs-versions:
when:
Expand All @@ -472,6 +495,7 @@ workflows:
# by providing the parameter "workflow: other-nodejs-versions"
- equal: [ other-nodejs-versions, << pipeline.parameters.workflow >> ]
jobs:
- "node-20"
- "node-18"
- "node-16"
- "node-14"
Expand Down
3 changes: 2 additions & 1 deletion native-dep-packs/rebuild-precompiled-addons.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ declare -A ABI_VERSIONS=( \
["93"]="16.20.2" \
["108"]="18.18.2" \
["115"]="20.3.0" \
)
["120"]="21.1.0" \
)

LIBC_VARIANTS=( \
"glibc" \
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
3 changes: 2 additions & 1 deletion packages/autoprofile/precompile/build-all-addons.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ const ABI_VERSIONS = {
83: '14.21.3',
93: '16.20.2',
108: '18.18.2',
115: '20.3.0'
115: '20.3.0',
120: '21.1.0'
};

function buildForPlatform(platform) {
Expand Down
4 changes: 2 additions & 2 deletions packages/autoprofile/precompile/build-single-addon.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ module.exports = exports = function buildSingleAddOn(abi, version) {
mkdirp.sync(addonDir);
}

let command = `node node_modules/node-gyp/bin/node-gyp.js rebuild --target=${version} --arch=x64`;
let command = `node node_modules/node-gyp/bin/node-gyp.js rebuild --target=${version} --arch=process.arch`;
const cwd = path.join(__dirname, '..');

// NOTE: for darwin, we execute the rebuild on the local developer machine
if (cwd !== '/opt/autoprofile') {
const rootGyp = path.join(__dirname, '..', '..', '..', 'node_modules');
// NOTE: Node v14 failed because of: https://github.com/nodejs/node-gyp/issues/2673
command = `node ${rootGyp}/node-gyp/bin/node-gyp.js rebuild --target=${version} --arch=x64`;
command = `node ${rootGyp}/node-gyp/bin/node-gyp.js rebuild --target=${version} --arch=process.arch`;
}

console.log(`Running "${command}" in directory "${cwd}".`);
Expand Down
Binary file not shown.
Binary file modified packages/shared-metrics/addons/darwin/x64/108/gcstats.js.tar.gz
Binary file not shown.
Binary file not shown.
Binary file modified packages/shared-metrics/addons/darwin/x64/115/gcstats.js.tar.gz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified packages/shared-metrics/addons/darwin/x64/83/gcstats.js.tar.gz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified packages/shared-metrics/addons/darwin/x64/93/gcstats.js.tar.gz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified packages/shared-metrics/addons/linux/x64/musl/115/gcstats.js.tar.gz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 comments on commit cf0d664

Please sign in to comment.