Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci+fix: Test Rails 6.1 & 7.0 on Ruby 3.X runtimes #310

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Conversation

Ferenc-
Copy link
Contributor

@Ferenc- Ferenc- commented Jun 13, 2023

No description provided.

@Ferenc- Ferenc- changed the title ci: Test Rails 6.1 on Ruby 3.X runtimes ci+fix: Test Rails 6.1 & 7.0 on Ruby 3.X runtimes Jun 15, 2023
@Ferenc- Ferenc- requested review from basti1302 and pvital June 15, 2023 22:13
Copy link
Contributor

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Otherwise *args can have too many arguments,
which often happened on Rails 6.1 and above with postgres.

ArgumentError: wrong number of arguments (given 6, expected 1..5)
[...]lib/active_record/connection_adapters/abstract_adapter.rb:759:in `log'

Signed-off-by: Ferenc Géczi <[email protected]>
@Ferenc- Ferenc- merged commit 997c77f into master Jun 19, 2023
2 checks passed
@Ferenc- Ferenc- deleted the rails-61-on-ruby-3 branch June 19, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants