Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use net-http gem in tests #388

Merged
merged 4 commits into from
May 29, 2024
Merged

ci: use net-http gem in tests #388

merged 4 commits into from
May 29, 2024

Conversation

GSVarsha
Copy link

No description provided.

Copy link
Contributor

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GSVarsha GSVarsha marked this pull request as ready for review May 29, 2024 06:24
@GSVarsha GSVarsha requested review from Ferenc- and pvital May 29, 2024 06:25
@GSVarsha GSVarsha self-assigned this May 29, 2024
.tekton/run_unittests.sh Outdated Show resolved Hide resolved
test/instrumentation/net_http_test.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Copy link
Contributor

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@GSVarsha GSVarsha merged commit 3ca7cd3 into master May 29, 2024
170 checks passed
@GSVarsha GSVarsha deleted the use-net-http-gem branch May 29, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants