Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing rails tests #413

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: failing rails tests #413

merged 1 commit into from
Aug 19, 2024

Conversation

arjun-rajappa
Copy link
Contributor

@arjun-rajappa arjun-rajappa commented Aug 14, 2024

Deprecated name argument in remove_connection was causing issues. Initial method signature was remove_connection(name = nil). So removing the argument in this test file will fix the tests and should not have any repercussions on other areas.

Signed-off-by: arjun-rajappa <[email protected]>
Copy link

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@arjun-rajappa arjun-rajappa merged commit 7114911 into master Aug 19, 2024
213 of 214 checks passed
@arjun-rajappa arjun-rajappa deleted the fix-failing-rails-tests branch August 19, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants