Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument ActiveRecord #49

Merged
merged 40 commits into from
Jan 21, 2017
Merged

Instrument ActiveRecord #49

merged 40 commits into from
Jan 21, 2017

Conversation

pglombardo
Copy link
Contributor

@pglombardo pglombardo commented Jan 19, 2017 •
edited
Loading

It's time to instrument ActiveRecord with each of its possible adapters (postgresql, mysql or mysql2).

  • Postgresql instrumentation
    • Rails 3
    • Rails 4
    • Rails 5
  • mysql instrumentation
    • Rails 3
    • Rails 4
    • Rails 5 (unsupported/discontinued)
  • mysql2 instrumentation
    • Rails 3
    • Rails 4
    • Rails 5
  • Add tests for all above
  • Sanitize reported SQL
  • Add UI bits: instana/ui-client#326
  • Add version matrix to Travis to test against multiple ActiveRecord versions

@pglombardo
Use multiple gemfiles with version exclusions.
1a5421d 
- Add gemfile for Rails 5.0.1 to test against
- Add exclusions: Rails 5 only supports Ruby version 2.2 or greater
@pglombardo
Add ActiveRecord instrumentation to Instana.config
5e8cf9f
@pglombardo
Further break out gem sets into separate gemfiles.
c72a5b2
@pglombardo
Make sure frameworks are defined before testing.
4fe20d4
@pglombardo
Fix Yaml syntax
4ce9052
@pglombardo
Load test files for rails when in rails bundle
6af3ae3
@pglombardo
Remove duplicate puma line.
8fb0fee
@pglombardo
Add ignore for Gemfile.lock files.
a4d9394
@pglombardo
No lock files; remove
6eebce1
@pglombardo
Add a rack version limiter for Ruby < 2.2
dd38b9f
@pglombardo
Include the postgres gem
e0fa7c4
@pglombardo
Rename to leave room for mysql2 version
70d3bbe
@pglombardo
Update Rails 5.0 postgres gemfile filename
6157f5e
@pglombardo
Allow in-test rails server to flip databases based on environment.
91f859c
@pglombardo
Add ActiveRecord to list of registered spans.
0549455
@pglombardo
Load ActiveRecord instrumentation _after_ Rails initializes
3825298
@pglombardo
ActiveRecord instrumentation for Rails 5/postgres.
3c78a78
@pglombardo
Add an ActiveRecord model to test against.
714c7db
@pglombardo
Tests for ActiveRecord postgres spans.
7da4e83
@pglombardo
Dummy dir for Rails server used in test suite
d3c62ae
@pglombardo
Add Rails 4.2 tests; splits tests per version
117b2ae
@pglombardo
Load Rails server for Rails 4.2 gemfile
c7076bd
@pglombardo
Include gemspec in Rails 4 bundle
a3098bd
@pglombardo
Add Rails 4 to Ruby 2 exclusion matrix
d145edb
@pglombardo
Add Rails 3.2 stack to tests.
83cd6ed
@pglombardo
ActiveRecord v3 tests.
b169480
@pglombardo
Sanitize all logged SQL statements.
e4a61e0
@pglombardo
Update SQL tests to follow sanitize changes.
dd83693
@pglombardo
Add varying Rails 3 migration method
01e2165
@pglombardo
Rename Rails server to generic
0f96cb6
@pglombardo pglombardo merged commit ed7ff42 into master Jan 21, 2017
@pglombardo pglombardo deleted the activerecord branch January 21, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pglombardo