Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate the terminal value in a DCF model #1298

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

crobb1
Copy link

@crobb1 crobb1 commented Sep 16, 2024

Adding a skill to calculate the terminal value in a DCF model. Currently, the model only gets this question about 1/2 way correct. this should help get it all the way there!
Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • [x ] All commits are signed off (DCO)
  • [x ] The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • [x ] Content does not include PII or otherwise sensitive or confidential information
  • [x ] Content does not include anything documented in the project's Avoid these Topics guidelines

Signed-off-by: Colin Robb <[email protected]>
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged skill (Auto labeled) labels Sep 16, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@jjasghar jjasghar changed the title Create qna.yaml calculate the terminal value in a DCF mode Sep 16, 2024
removed the colons; this now passed a YAML validator test. 

Signed-off-by: Colin Robb <[email protected]>
@mcorbin-ibm
Copy link
Contributor

From a taxonomy tree perspective, this would go here:

compositional_skills/grounded/science/social_sciences/economics/dcf_model

In the DDC summaries, "economics" is under "social sciences" which is separate from "science" but for InstructLab, I think we should just put social sciences under our science main category.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linting issues.

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels Sep 24, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@crobb1 crobb1 changed the title calculate the terminal value in a DCF mode calculate the terminal value in a DCF model Sep 27, 2024
I fixed the trailing spaces issues and made it version 3.

Signed-off-by: Colin Robb <[email protected]>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Sep 27, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

Signed-off-by: Colin Robb <[email protected]>
@crobb1
Copy link
Author

crobb1 commented Sep 27, 2024

I updated the qna and addressed the linting issues. I also added the attribution.txt file with the source.

Copy link

This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Oct 13, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@crobb1
Copy link
Author

crobb1 commented Oct 14, 2024

Noticing this has been marked stale; I think my updates from 2 weeks ago should be good now. Let me know if there's anything else I need to do. Thanks.

@mcorbin-ibm
Copy link
Contributor

@jjasghar @crobb1

Not sure if the triage team needed to review/discuss this one, but I had suggested a different location in the taxonomy tree for this one: #1298 (comment)

@github-actions github-actions bot removed the stale stale-bot has marked you as stale label Oct 15, 2024
…/grounded/science/social_sciences/economics/dcf_model

Changing to recommended location.

Signed-off-by: Colin Robb <[email protected]>
…_skills/grounded/science/social_sciences/economics/attribution.txt

Changing to recommended location

Signed-off-by: Colin Robb <[email protected]>
@crobb1
Copy link
Author

crobb1 commented Oct 15, 2024

Okay - I updated to the recommended location.

@jjasghar
Copy link
Member

Hi! Until we have our community model builds back up and running, many PRs will be held off. We are hoping to have them running again soon, and if you have any specific questions don't hesitate to comment here or reach out to #triage in slack.

Copy link

github-actions bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Nov 1, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@crobb1
Copy link
Author

crobb1 commented Nov 11, 2024

Just wanted to check in and see if there is anything else to progress this contribution? I think it's ready once the community model builds are back up.

@jjasghar
Copy link
Member

We had a long time before the community model build is running at full capacity, unfortunately. We are attempting to get it working but have encountered some logistical issues. We are working on them, but it's slow going.

@github-actions github-actions bot removed the stale stale-bot has marked you as stale label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill (Auto labeled) triage-needed (Auto labeled) skill is ready to be triaged triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants