fix(ui-tree-browser): TreeBrowser collection descriptor is now read b… #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToMESSKa
changed the title
|
ToMESSKa
force-pushed
the
INSTUI-4296_parts_of_tree_browser_items_are_not_read_by_screenreaders
branch
from
b97ac10
to
c92ba29
Compare
ToMESSKa
changed the title
…ced by screenreaders Closes: INSTUI-4296
ToMESSKa
force-pushed
the
INSTUI-4296_parts_of_tree_browser_items_are_not_read_by_screenreaders
branch
from
c92ba29
to
0b64f8d
Compare
ToMESSKa
commented
Oct 18, 2024
| return child.getDOMNode().ariaLabel | ||
| return child | ||
| .getDOMNode() | ||
| .querySelector('span[class$="treeButton__textName"]')?.textContent |
There was a problem hiding this comment.
Here tests were adjusted because they utilized the "incorrect" aria-labels. Also checked with Nándi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y screenreaders
Closes: INSTUI-4296
ISSUE:
When navigating through a TreeBrowser component, the descriptor of a collection is not read
TEST PLAN:
TabkeyControl + Option + Shift + Down Arrow(Mac) orDown Arrow(Windows) key to enter the tree