Skip to content
This repository has been archived by the owner on Dec 22, 2018. It is now read-only.

update build script so that running with npm start works #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KaneMorgan
Copy link

I think this addresses #19 but it may have been a different root cause looking at the dates

@KaneMorgan KaneMorgan closed this Jun 21, 2017
@KaneMorgan KaneMorgan mentioned this pull request Jul 20, 2017
@Nyceane
Copy link

Nyceane commented Apr 24, 2018

@KaneMorgan this still have the problem, not sure why you closed it

@KaneMorgan
Copy link
Author

It didn't seem like this was still under active development. From what I can remember the bug is just that its looking at the wrong directory in the script, it should be looking at the doc rather than the web directory.

I started looking at this fork that someone else made https://github.com/DynamicEnvironmentSystems/pdf-annotate.js

I'm not actively looking at this anymore but it does fix an issue with getting started so I'll reopen it.

@KaneMorgan KaneMorgan reopened this Apr 24, 2018
@CLAassistant
Copy link

CLAassistant commented Apr 24, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kane Morgan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants