Refactor test (#630)

int128 · Apr 2, 2023 · c7b18a0 · c7b18a0
1 parent 2498ea5
commit c7b18a0
Showing 1 changed file with 13 additions and 17 deletions.
diff --git a/tests/run.test.ts b/tests/run.test.ts
@@ -24,16 +24,12 @@ const getOctokit = github.getOctokit as jest.Mock
 getOctokit.mockReturnValue(octokitMock)
 
 jest.mock('@datadog/datadog-api-client')
-const metricsApiMock = {
-  submitMetrics: jest.fn<Promise<v1.IntakePayloadAccepted>, [v1.MetricsApiSubmitMetricsRequest]>(),
-}
-const metricsApiConstructor = v1.MetricsApi as jest.Mock
-metricsApiConstructor.mockReturnValue(metricsApiMock)
+const submitMetrics = jest.spyOn(v1.MetricsApi.prototype, 'submitMetrics')
 
 test('workflow_run with collectJobMetrics', async () => {
   octokitMock.graphql.mockResolvedValue(exampleCompletedCheckSuite)
   octokitMock.rest.rateLimit.get.mockResolvedValue(exampleRateLimitResponse)
-  metricsApiMock.submitMetrics.mockResolvedValue({ status: 'ok' })
+  submitMetrics.mockResolvedValue({ status: 'ok' })
 
   await run(
     {
@@ -51,13 +47,13 @@ test('workflow_run with collectJobMetrics', async () => {
     }
   )
   expect(getOctokit).toHaveBeenCalledWith('GITHUB_TOKEN')
-  expect(metricsApiMock.submitMetrics).toHaveBeenCalledTimes(4)
-  expect(metricsApiMock.submitMetrics.mock.calls).toMatchSnapshot()
+  expect(submitMetrics).toHaveBeenCalledTimes(4)
+  expect(submitMetrics.mock.calls).toMatchSnapshot()
 })
 
 test('workflow_run', async () => {
   octokitMock.rest.rateLimit.get.mockResolvedValue(exampleRateLimitResponse)
-  metricsApiMock.submitMetrics.mockResolvedValue({ status: 'ok' })
+  submitMetrics.mockResolvedValue({ status: 'ok' })
 
   await run(
     {
@@ -75,13 +71,13 @@ test('workflow_run', async () => {
     }
   )
   expect(getOctokit).toHaveBeenCalledWith('GITHUB_TOKEN')
-  expect(metricsApiMock.submitMetrics).toHaveBeenCalledTimes(2)
-  expect(metricsApiMock.submitMetrics.mock.calls).toMatchSnapshot()
+  expect(submitMetrics).toHaveBeenCalledTimes(2)
+  expect(submitMetrics.mock.calls).toMatchSnapshot()
 })
 
 test('pull_request_opened', async () => {
   octokitMock.rest.rateLimit.get.mockResolvedValue(exampleRateLimitResponse)
-  metricsApiMock.submitMetrics.mockResolvedValue({ status: 'ok' })
+  submitMetrics.mockResolvedValue({ status: 'ok' })
 
   await run(
     {
@@ -99,14 +95,14 @@ test('pull_request_opened', async () => {
     }
   )
   expect(getOctokit).toHaveBeenCalledWith('GITHUB_TOKEN')
-  expect(metricsApiMock.submitMetrics).toHaveBeenCalledTimes(2)
-  expect(metricsApiMock.submitMetrics.mock.calls).toMatchSnapshot()
+  expect(submitMetrics).toHaveBeenCalledTimes(2)
+  expect(submitMetrics.mock.calls).toMatchSnapshot()
 })
 
 test('pull_request_closed', async () => {
   octokitMock.graphql.mockResolvedValue(exampleClosedPullRequestQuery)
   octokitMock.rest.rateLimit.get.mockResolvedValue(exampleRateLimitResponse)
-  metricsApiMock.submitMetrics.mockResolvedValue({ status: 'ok' })
+  submitMetrics.mockResolvedValue({ status: 'ok' })
 
   await run(
     {
@@ -124,6 +120,6 @@ test('pull_request_closed', async () => {
     }
   )
   expect(getOctokit).toHaveBeenCalledWith('GITHUB_TOKEN')
-  expect(metricsApiMock.submitMetrics).toHaveBeenCalledTimes(2)
-  expect(metricsApiMock.submitMetrics.mock.calls).toMatchSnapshot()
+  expect(submitMetrics).toHaveBeenCalledTimes(2)
+  expect(submitMetrics.mock.calls).toMatchSnapshot()
 })