Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the command args at stage 2 instructions #261

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Mar 28, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #261 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   70.19%   70.19%           
=======================================
  Files          20       20           
  Lines         718      718           
=======================================
  Hits          504      504           
  Misses        149      149           
  Partials       65       65           
Impacted Files Coverage Δ
pkg/usecases/setup/stage2.go 67.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc1568...1c407ce. Read the comment docs.

@int128 int128 merged commit 7f4f72c into int128:master Mar 29, 2020
@int128
Copy link
Owner

int128 commented Mar 29, 2020

Thank you for your contribution.

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Mar 29, 2020

@int128 thanks for adopting my patch! There might be other occurrences of the same issue across the code base, and frankly, the way I fixed it is not the best one.
A better way would be to add a template helper function that would wrap the array of string with adding the \ for each except the last one.

@MOZGIII MOZGIII deleted the patch-1 branch March 29, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants