Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check type of path #63

Merged
merged 20 commits into from
Jan 12, 2022
Merged

check type of path #63

merged 20 commits into from
Jan 12, 2022

Conversation

aaronspring
Copy link
Collaborator

otherwise uninformative error message: KeyError trying to assess first element of str instead of first element of list

aaronspring
aaronspring commented Jan 3, 2022
View reviewed changes
intake_thredds/source.py Outdated Show resolved Hide resolved
@aaronspring @andersy005
Update intake_thredds/source.py
59a14ac 
Co-authored-by: Anderson Banihirwe <[email protected]>
aaronspring
aaronspring commented Jan 10, 2022
View reviewed changes
intake_thredds/source.py Outdated Show resolved Hide resolved
@dopplershift
Copy link
Collaborator

Peanut gallery here, but a more Pythonic way would be to raise ValueError for problems with input rather than an assert.

@aaronspring
Copy link
Collaborator Author

Peanut gallery here, but a more Pythonic way would be to raise ValueError for problems with input rather than an assert.

thanks and implemented

@aaronspring aaronspring marked this pull request as ready for review January 11, 2022 13:02
@aaronspring aaronspring self-assigned this Jan 11, 2022
@aaronspring aaronspring added documentation enhancement New feature or request labels Jan 11, 2022
andersy005
andersy005 reviewed Jan 11, 2022
View reviewed changes
tests/test_source.py Outdated Show resolved Hide resolved
aaronspring and others added 2 commits January 12, 2022 12:23
@aaronspring
Update source.py
13e480a
@aaronspring @andersy005
separate tests
18a5655 
Co-authored-by: Anderson Banihirwe <[email protected]>
andersy005
andersy005 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aaronspring!

@andersy005 andersy005 merged commit 2a699a4 into main Jan 12, 2022
@andersy005 andersy005 deleted the check_path_type branch January 12, 2022 16:10
@aaronspring
Copy link
Collaborator Author

Thanks for the review and coding suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees

@aaronspring aaronspring

Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronspring @dopplershift @andersy005