Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 to GHA #129

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Add Python 3.11 to GHA #129

merged 10 commits into from
Feb 7, 2024

Conversation

gliptak
Copy link
Collaborator

@gliptak gliptak commented Feb 2, 2024

No description provided.

@gliptak
Copy link
Collaborator Author

gliptak commented Feb 2, 2024

  + delocate-wheel --require-archs x86_64,arm64 -w /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cibw-run-4t7bwcty/cp38-macosx_universal2/repaired_wheel -v /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cibw-run-4t7bwcty/cp38-macosx_universal2/built_wheel/python_snappy-0.6.1-cp38-cp38-macosx_10_9_universal2.whl
  INFO:delocate.delocating:Copying library /usr/local/Cellar/snappy/1.1.10/lib/libsnappy.1.1.10.dylib to snappy/.dylibs/libsnappy.1.1.10.dylib
  INFO:delocate.delocating:Modifying install name in snappy/_snappy.cpython-38-darwin.so from /usr/local/opt/snappy/lib/libsnappy.1.dylib to @loader_path/.dylibs/libsnappy.1.1.10.dylib
  Fixing: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cibw-run-4t7bwcty/cp38-macosx_universal2/built_wheel/python_snappy-0.6.1-cp38-cp38-macosx_10_9_universal2.whl
  Traceback (most recent call last):
    File "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cibw-run-4t7bwcty/cp38-macosx_universal2/build/venv/bin/delocate-wheel", line 8, in <module>
      sys.exit(main())
    File "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cibw-run-4t7bwcty/cp38-macosx_universal2/build/venv/lib/python3.8/site-packages/delocate/cmd/delocate_wheel.py", line 128, in main
      copied = delocate_wheel(
    File "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/cibw-run-4t7bwcty/cp38-macosx_universal2/build/venv/lib/python3.8/site-packages/delocate/delocating.py", line 662, in delocate_wheel
      raise DelocationError(
  delocate.delocating.DelocationError: Some missing architectures in wheel
  Required arch arm64 missing from snappy/_snappy.cpython-38-darwin.so

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@martindurant
Copy link
Member

@gliptak , instead of updating the build and code for this package, would you perhaps consider making a PR to use the rust-based cramjam, which includes all the functionality made here? This package would become just a thin wrapper to satisfy dependencies.

@gliptak
Copy link
Collaborator Author

gliptak commented Feb 2, 2024

thank you for the tag @martindurant https://github.com/milesgranger/cramjam sounds like a bigger update

might you be open to merge/publish this PR first (assuming that I can get it to green)?

@martindurant
Copy link
Member

might you be open to merge/publish this PR first

Certainly, but in the meantime, py3.12 is out and 3.13 on the way, so we are already behind. 3.7 should definitely be dropped and maybe 3.8 too.

@gliptak
Copy link
Collaborator Author

gliptak commented Feb 2, 2024

@martindurant
Copy link
Member

I has everything we need, no? If we can provide [stream]-de/compress, good enough I think.

@gliptak
Copy link
Collaborator Author

gliptak commented Feb 7, 2024

#127

@martindurant
Copy link
Member

Merging from main, we no longer need to build wheels at all, this package has become noarch!

@gliptak
Copy link
Collaborator Author

gliptak commented Feb 7, 2024

🚀

setup.py Outdated Show resolved Hide resolved
@martindurant martindurant merged commit c381afc into intake:master Feb 7, 2024
9 checks passed
@gliptak gliptak deleted the python1 branch February 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants