Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Date.now #167

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Mock Date.now #167

merged 1 commit into from
Dec 5, 2017

Conversation

bkeepers
Copy link
Contributor

@bkeepers bkeepers commented Dec 5, 2017

This is an alternative to #166. This mocks Date.now to be a fixed time, as suggested in this jest discussion.

wilhelmklopp
wilhelmklopp approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@wilhelmklopp wilhelmklopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this. Seems much cleaner 👍

Hopefully the global aspect of it doesn't have any weird unintended ramifications

@wilhelmklopp wilhelmklopp mentioned this pull request Dec 5, 2017
Merged
@bkeepers bkeepers merged commit 663b1b7 into master Dec 5, 2017
@bkeepers bkeepers deleted the date-now branch December 5, 2017 18:00
@wilhelmklopp wilhelmklopp mentioned this pull request Feb 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilhelmklopp wilhelmklopp wilhelmklopp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkeepers @wilhelmklopp