-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run go mod tidy on release #1788
Merged
kfcampbell
merged 2 commits into
integrations:main
from
kfcampbell:do-not-tidy-on-release
Jul 11, 2023
Merged
Don't run go mod tidy on release #1788
kfcampbell
merged 2 commits into
integrations:main
from
kfcampbell:do-not-tidy-on-release
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
doonga
referenced
this pull request
in doonga/greyrock-ops
Jul 12, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | minor | `5.29.0` -> `5.30.1` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.30.1`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.30.1) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.29.0...v5.30.1) #### What's Changed - Fix: incorrect field name in docs for github_repository_collaborators by [@​Jeffreyhung](https://togithub.com/Jeffreyhung) in [https://github.com/integrations/terraform-provider-github/pull/1779](https://togithub.com/integrations/terraform-provider-github/pull/1779) - fix: remove validation for team.permission on `github_repository_collaborators` by [@​jsifuentes](https://togithub.com/jsifuentes) in [https://github.com/integrations/terraform-provider-github/pull/1781](https://togithub.com/integrations/terraform-provider-github/pull/1781) - build(deps): bump golang.org/x/crypto from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/1784](https://togithub.com/integrations/terraform-provider-github/pull/1784) - Don't run go mod tidy on release by [@​kfcampbell](https://togithub.com/kfcampbell) in [https://github.com/integrations/terraform-provider-github/pull/1788](https://togithub.com/integrations/terraform-provider-github/pull/1788) #### New Contributors - [@​Jeffreyhung](https://togithub.com/Jeffreyhung) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1779](https://togithub.com/integrations/terraform-provider-github/pull/1779) - [@​jsifuentes](https://togithub.com/jsifuentes) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/1781](https://togithub.com/integrations/terraform-provider-github/pull/1781) **Full Changelog**: integrations/terraform-provider-github@v5.30.0...v5.30.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
dcfranca
pushed a commit
to dcfranca/terraform-provider-github
that referenced
this pull request
Jul 14, 2023
* Don't run go mod tidy on release * Be more specific about releases
felixlut
pushed a commit
to felixlut/terraform-provider-github
that referenced
this pull request
Jul 22, 2023
* Don't run go mod tidy on release * Be more specific about releases
kfcampbell
added a commit
that referenced
this pull request
Jan 10, 2024
* Add retryable transport for errors In order to address the issue #210 I have added 3 new parameters to the provider - retry_delay_ms - max_retries - retryable_errors In case max_retries is > 0 (defaults to zero) it will retry the request in case it is an error the retryable_errors defaults to [500, 502, 503, 504] It retries after the ms specified in retry_delay_ms (defaults to 1000) * Update documentation with new parameters for retry * Change default of max_retries to 3 * Fix typo in naming * Update github/transport_test.go * Add error check for data seek * Consolidate the default retriable errors on a function * Fix typo on the comments Co-authored-by: Keegan Campbell <[email protected]> * Update vendor * Fix merging conflicts * Update documentation with new parameters for retry * Change default of max_retries to 3 * Fix typo in naming * Add error check for data seek * Update github/transport_test.go * Consolidate the default retriable errors on a function * Fix typo on the comments Co-authored-by: Keegan Campbell <[email protected]> * Don't run go mod tidy on release (#1788) * Don't run go mod tidy on release * Be more specific about releases * Fix lint with APIMeta deprecation --------- Co-authored-by: Keegan Campbell <[email protected]> Co-authored-by: Nick Floyd <[email protected]>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* Don't run go mod tidy on release * Be more specific about releases
kfcampbell
added a commit
that referenced
this pull request
Feb 16, 2024
* Add retryable transport for errors (#1704) * Add retryable transport for errors In order to address the issue #210 I have added 3 new parameters to the provider - retry_delay_ms - max_retries - retryable_errors In case max_retries is > 0 (defaults to zero) it will retry the request in case it is an error the retryable_errors defaults to [500, 502, 503, 504] It retries after the ms specified in retry_delay_ms (defaults to 1000) * Update documentation with new parameters for retry * Change default of max_retries to 3 * Fix typo in naming * Update github/transport_test.go * Add error check for data seek * Consolidate the default retriable errors on a function * Fix typo on the comments Co-authored-by: Keegan Campbell <[email protected]> * Update vendor * Fix merging conflicts * Update documentation with new parameters for retry * Change default of max_retries to 3 * Fix typo in naming * Add error check for data seek * Update github/transport_test.go * Consolidate the default retriable errors on a function * Fix typo on the comments Co-authored-by: Keegan Campbell <[email protected]> * Don't run go mod tidy on release (#1788) * Don't run go mod tidy on release * Be more specific about releases * Fix lint with APIMeta deprecation --------- Co-authored-by: Keegan Campbell <[email protected]> Co-authored-by: Nick Floyd <[email protected]> * fix: remove repository topic from state if it doesnt exist in GitHub anymore (#1918) * remove repository topic if they cannot be found in GitHub anymore * Fix build error by bumping package version in offending file --------- Co-authored-by: Keegan Campbell <[email protected]> * Bump version to v6 (#2106) * Upgrade to Terraform Plugin SDK v2 (#1780) * go mod tidy -go=1.16 && go mod tidy -go=1.17 * Run go mod vendor * Attempt v2 upgrade * Plugin compiling * Fix some provider test errors * Fix test compilation error * ValidateFunc --> ValidateDiagFunc * Fix casing * Sprinkle toDiagFunc everywhere * More fixes for validation functions * State --> StateContext * %s --> %v when printing diags * ConfigureFunc --> ConfigureContextFunc * Checking results of d.Set, round one * Continue checking d.Set results * Check results of d.Set, round three * Checking d.Set results, round four * d.Set round five * In tests, export GITHUB_TEST_ORGANIZATION * Remove unnecessary MaxItems on computed value * Go build now works * Resolve linting errors * Apply diag.FromErr twice more * Pass key names into toDiagFunc helper * Construct cty.Path from strings * Tests now working * Update terraform-plugin-sdk version * Remove commented attribute setting in resource_github_team.go * Fix restrict pushes on github_branch_protection. Fix branch protection tests (#2045) * Update restrict pushes. Fix branch protection tests Change blocks_creations default to true. Fix broken build. * add state migration * rename push_restrictions to push_allowances * correct state migration issue * add docs clarification * update migration func args * fix test args * cleanup tests * Pass context.Background() in test * fix timestamp fields --------- Co-authored-by: Keegan Campbell <[email protected]> * Set group_id correctly (#2133) * Run go get -u github.com/golangci/golangci-lint * Separate github_team_members import from github_team as create_default_maintainers is not defined for members resource (#2126) Co-authored-by: Keegan Campbell <[email protected]> * Add missing variable definition for test case --------- Co-authored-by: Daniel França <[email protected]> Co-authored-by: Nick Floyd <[email protected]> Co-authored-by: Felix Luthman <[email protected]> Co-authored-by: georgekaz <[email protected]> Co-authored-by: Rich Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will temporarily unblock releases. The more permanent solution is present in #1780.