Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prevent_self_review parameter to the github_repository_environment resource #2000

Merged
merged 3 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions github/resource_github_repository_environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ func resourceGithubRepositoryEnvironment() *schema.Resource {
Default: true,
Description: "Can Admins bypass deployment protections",
},
"prevent_self_review": {
Type: schema.TypeBool,
Optional: true,
Default: false,
Description: "Prevent users from approving workflows runs that they triggered.",
},
"wait_timer": {
Type: schema.TypeInt,
Optional: true,
Expand Down Expand Up @@ -170,6 +176,8 @@ func resourceGithubRepositoryEnvironmentRead(d *schema.ResourceData, meta interf
"users": users,
},
})

d.Set("prevent_self_review", pr.PreventSelfReview)
}
}

Expand Down Expand Up @@ -233,6 +241,8 @@ func createUpdateEnvironmentData(d *schema.ResourceData, meta interface{}) githu

data.CanAdminsBypass = github.Bool(d.Get("can_admins_bypass").(bool))

data.PreventSelfReview = github.Bool(d.Get("prevent_self_review").(bool))

if v, ok := d.GetOk("reviewers"); ok {
envReviewers := make([]*github.EnvReviewers, 0)

Expand Down
2 changes: 2 additions & 0 deletions github/resource_github_repository_environment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func TestAccGithubRepositoryEnvironment(t *testing.T) {
environment = "environment / test"
can_admins_bypass = false
wait_timer = 10000
prevent_self_review = true
reviewers {
users = [data.github_user.current.id]
}
Expand All @@ -44,6 +45,7 @@ func TestAccGithubRepositoryEnvironment(t *testing.T) {
check := resource.ComposeAggregateTestCheckFunc(
resource.TestCheckResourceAttr("github_repository_environment.test", "environment", "environment / test"),
resource.TestCheckResourceAttr("github_repository_environment.test", "can_admins_bypass", "false"),
resource.TestCheckResourceAttr("github_repository_environment.test", "prevent_self_review", "true"),
resource.TestCheckResourceAttr("github_repository_environment.test", "wait_timer", "10000"),
)

Expand Down
13 changes: 8 additions & 5 deletions website/docs/r/repository_environment.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,19 @@ data "github_user" "current" {
}

resource "github_repository" "example" {
name = "A Repository Project"
description = "My awesome codebase"
name = "A Repository Project"
description = "My awesome codebase"
}

resource "github_repository_environment" "example" {
environment = "example"
repository = github_repository.example.name
environment = "example"
repository = github_repository.example.name
prevent_self_review = true
reviewers {
users = [data.github_user.current.id]
}
deployment_branch_policy {
protected_branches = true
protected_branches = true
custom_branch_policies = false
}
}
Expand All @@ -46,6 +47,8 @@ The following arguments are supported:

* `can_admins_bypass` - (Optional) Can repository admins bypass the environment protections. Defaults to `true`.

* `prevent_self_review` - (Optional) Whether or not a user who created the job is prevented from approving their own job. Defaults to `false`.

### Reviewers

The `reviewers` block supports the following:
Expand Down