-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for web commit sign off #2007
add support for web commit sign off #2007
Conversation
Signed-off-by: Rumen Vasilev <[email protected]>
Signed-off-by: Rumen Vasilev <[email protected]>
@@ -678,6 +685,7 @@ func resourceGithubRepositoryRead(d *schema.ResourceData, meta interface{}) erro | |||
d.Set("allow_squash_merge", repo.GetAllowSquashMerge()) | |||
d.Set("allow_update_branch", repo.GetAllowUpdateBranch()) | |||
d.Set("delete_branch_on_merge", repo.GetDeleteBranchOnMerge()) | |||
d.Set("web_commit_signoff_required", repo.GetWebCommitSignoffRequired()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be set somewhere in the Create/Update methods as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I miss adding it somewhere? I’ve tested this feature and it works as expected (adding, removing, updating the setting).
Is it possible that you’re asking for the other PR (the bug for gitcommit paginated call)?
@kfcampbell is there a reason you are not merging this? |
It slipped through the cracks for me; apologies. I'll get it merged and released soon. |
* add support for web commit sign off Signed-off-by: Rumen Vasilev <[email protected]> * include test assertion Signed-off-by: Rumen Vasilev <[email protected]> --------- Signed-off-by: Rumen Vasilev <[email protected]> Co-authored-by: Keegan Campbell <[email protected]>
Resolves #2006
Before the change?
After the change?
web_commit_signoff_required
allows you to toggle this on or off (off by default).Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!