Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for merge queues in repository rulesets #2380

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add support for merge queues in repository rulesets #2380

wants to merge 4 commits into from

Conversation

MXfive
Copy link

@MXfive MXfive commented Sep 6, 2024 •
edited
Loading

Resolves #1481

Before the change?

  • Does not support merge queue rules on rulesets.

After the change?

  • Supports merge queue rules on rulesets

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@MXfive
Copy link
Author

MXfive commented Sep 6, 2024 •
edited
Loading

Waiting for SDK to be released before rebasing and putting for review. Wanted to get some early feedback on:

  1. The code, any issues or changes needed? Quite simple following the other code in that context, descriptions copy pasted from upstream API docs verbatim.
  2. Testing, I added the block to the only tests I found referencing these rules, though giving incomplete inputs to these blocks does not fail the tests.
    3. Not yet checked where to add docs, will have a look if I have time over the weekend.

@MXfive MXfive mentioned this pull request Sep 6, 2024
Open
1 task
@MXfive MXfive marked this pull request as ready for review September 17, 2024 01:47
@MXfive MXfive changed the title feat: add support for merge queues in repository and organization rulesets feat: add support for merge queues in repository rulesets Oct 2, 2024
@zepeng811
Copy link
Contributor

@MXfive #2359 have been merged, can you help rebase your PR

@MXfive
Copy link
Author

MXfive commented Oct 3, 2024

@kfcampbell This is ready for review now :)

@MXfive MXfive requested a review from kfcampbell October 3, 2024 05:57
@joshmyers
Copy link

Love to see this go in 🙏

@bsgrigorov
Copy link

This would be very useful for us.

@MXfive MXfive force-pushed the main branch 2 times, most recently from 02b1017 to da0f157 Compare October 24, 2024 02:39
@muhlba91
Copy link

it would be awesome if this could be merged soon.

@zepeng811
Copy link
Contributor

@kfcampbell @nickfloyd gentle bump, can we get some eyes on this PR please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepeng811 zepeng811 zepeng811 approved these changes

@kfcampbell kfcampbell Awaiting requested review from kfcampbell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add support for Merge queue on github.
6 participants
@MXfive @zepeng811 @joshmyers @bsgrigorov @muhlba91 @kfcampbell