Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(r/repository): suppress etag changes #909

Merged
merged 1 commit into from
Sep 22, 2021
Merged

fix(r/repository): suppress etag changes #909

merged 1 commit into from
Sep 22, 2021

Conversation

jcudit
Copy link
Contributor

@jcudit jcudit commented Sep 21, 2021

/cc #796

@jcudit jcudit added this to the v4.15.0 milestone Sep 21, 2021
kfcampbell
kfcampbell approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to reproduce the changing etag issue recently with several repository creations. That being said, I can't remember ever caring about the etag output and it's good with me to suppress it by default.

@jcudit jcudit merged commit 654b4e5 into main Sep 22, 2021
@jcudit jcudit deleted the fix/repository/796 branch September 22, 2021 21:49
@k24dizzle
Copy link
Contributor

Is anyone else running into this following error?

Error: Internal validation of the provider failed! This is always a bug
with the provider itself, and not a user issue. Please report
this bug:

1 error occurred:
	* resource github_repository: etag: DiffSuppressFunc is for suppressing differences between config and state representation. There is no config for computed-only field, nothing to compare.

@starhawking
Copy link
Contributor

Is anyone else running into this following error?

Error: Internal validation of the provider failed! This is always a bug
with the provider itself, and not a user issue. Please report
this bug:

1 error occurred:
	* resource github_repository: etag: DiffSuppressFunc is for suppressing differences between config and state representation. There is no config for computed-only field, nothing to compare.

I just ran into this myself! Everything worked again when I backed out this change

@starhawking
Copy link
Contributor

starhawking commented Sep 22, 2021 •
edited
Loading

Looks like the tests caught this, but they were turned off a while back

554df9f

=== RUN   TestProvider/has_an_implementation
--- FAIL: TestProvider (0.00s)
    --- FAIL: TestProvider/runs_internal_validation_without_error (0.00s)
    --- PASS: TestProvider/has_an_implementation (0.00s)

@james-callahan james-callahan mentioned this pull request Sep 23, 2021
Closed
niels-s added a commit to niels-s/terraform-provider-github that referenced this pull request Jul 8, 2022
@niels-s
chore: surpress ETag changes
9d13729 
Suppress the ETag changes for the `github_membership`, `github_team` and
`github_team_members`.
Following the example of
integrations#909.

Ignoring these changes with LifeCycle rules didn't work either.
niels-s added a commit to niels-s/terraform-provider-github that referenced this pull request Jul 8, 2022
@niels-s
feat: surpress ETag changes for member resources
2c3b5a0 
Suppress the ETag changes for the `github_membership`, `github_team` and
`github_team_members`. Following the example of
integrations#909.

Ignoring these changes with LifeCycle rules didn't work either.
@niels-s niels-s mentioned this pull request Jul 8, 2022
Closed
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
fix(r/repository): suppress etag changes (integrations#909)
8056c81 
/cc integrations#796
@rudineirk rudineirk mentioned this pull request Sep 26, 2022
Open
@aamkye aamkye mentioned this pull request Jun 21, 2024
Closed
4 tasks
@aamkye aamkye mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jcudit @k24dizzle @starhawking @kfcampbell