Get state does not sync with layer one chain #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
approved these changes
Jul 28, 2021
| @@ -49,7 +49,7 @@ pub fn run_enclave_tests(matches: &ArgMatches, port: &str) { | |||
| if matches.is_present("all") || matches.is_present("ecall") { | |||
| println!("Running ecall Tests"); | |||
| println!(" testing get_state()"); | |||
| get_state_works(&enclave); | |||
| get_state_works(&enclave).unwrap(); | |||
There was a problem hiding this comment.
This wasn't a bug - I just changed the function to return a result, moving the unwrap from inside the test function to the test client 😄
There was a problem hiding this comment.
Yes but still, I might have forgotten to add it here. :) Although, you probably got a warning of an unused result here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163