Skip to content

Commit

Permalink
selftests/bpf: Add test for __nullable suffix in tp_btf
Browse files Browse the repository at this point in the history
Add a tracepoint with __nullable suffix in bpf_testmod, and add a
failure load case:

$./test_progs -t "module_attach"
 torvalds#173/1   module_attach/handle_tp_btf_nullable_bare:OK
 torvalds#173     module_attach:OK
 Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Philo Lu <[email protected]>
  • Loading branch information
Philo Lu authored and intel-lab-lkp committed Sep 5, 2024
1 parent 8856cf0 commit 0742f10
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 1 deletion.
6 changes: 6 additions & 0 deletions tools/testing/selftests/bpf/bpf_testmod/bpf_testmod-events.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ DECLARE_TRACE(bpf_testmod_test_write_bare,
TP_ARGS(task, ctx)
);

/* Used in bpf_testmod_test_read() to test __nullable suffix */
DECLARE_TRACE(bpf_testmod_test_nullable_bare,
TP_PROTO(struct bpf_testmod_test_read_ctx *ctx__nullable),
TP_ARGS(ctx__nullable)
);

#undef BPF_TESTMOD_DECLARE_TRACE
#ifdef DECLARE_TRACE_WRITABLE
#define BPF_TESTMOD_DECLARE_TRACE(call, proto, args, size) \
Expand Down
2 changes: 2 additions & 0 deletions tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,8 @@ bpf_testmod_test_read(struct file *file, struct kobject *kobj,
if (bpf_testmod_loop_test(101) > 100)
trace_bpf_testmod_test_read(current, &ctx);

trace_bpf_testmod_test_nullable_bare(NULL);

/* Magic number to enable writable tp */
if (len == 64) {
struct bpf_testmod_test_writable_ctx writable = {
Expand Down
14 changes: 13 additions & 1 deletion tools/testing/selftests/bpf/prog_tests/module_attach.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <test_progs.h>
#include <stdbool.h>
#include "test_module_attach.skel.h"
#include "test_module_attach_fail.skel.h"
#include "testing_helpers.h"

static int duration;
Expand Down Expand Up @@ -33,7 +34,7 @@ static int trigger_module_test_writable(int *val)
return 0;
}

void test_module_attach(void)
static void module_attach_succ(void)
{
const int READ_SZ = 456;
const int WRITE_SZ = 457;
Expand Down Expand Up @@ -115,3 +116,14 @@ void test_module_attach(void)
cleanup:
test_module_attach__destroy(skel);
}

static void module_attach_fail(void)
{
RUN_TESTS(test_module_attach_fail);
}

void test_module_attach(void)
{
module_attach_succ();
module_attach_fail();
}
16 changes: 16 additions & 0 deletions tools/testing/selftests/bpf/progs/test_module_attach_fail.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// SPDX-License-Identifier: GPL-2.0

#include "vmlinux.h"
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_tracing.h>
#include "../bpf_testmod/bpf_testmod.h"
#include "bpf_misc.h"

SEC("tp_btf/bpf_testmod_test_nullable_bare")
__failure __msg("invalid mem access")
int BPF_PROG(handle_tp_btf_nullable_bare, struct bpf_testmod_test_read_ctx *nullable_ctx)
{
return nullable_ctx->len;
}

char _license[] SEC("license") = "GPL";

0 comments on commit 0742f10

Please sign in to comment.