Squash-to: "mptcp: handle consistently DSS corruption"

Instead of re-inventing the wheel, use the flag we already track to easily check if fallback is allowed. Note that we could not check conn_list in a reliable way, as the call side is not under the msk socket lock. Signed-off-by: Paolo Abeni <[email protected]>
intel-lab-lkp · Oct 2, 2024 · abaa958 · abaa958
1 parent ecea735
commit abaa958
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
@@ -622,7 +622,7 @@ static bool mptcp_check_data_fin(struct sock *sk)
 
 static void mptcp_dss_corruption(struct mptcp_sock *msk, struct sock *ssk)
 {
-	if (list_is_singular(&msk->conn_list) && msk->first == ssk) {
+	if (READ_ONCE(msk->allow_infinite_fallback)) {
 		MPTCP_INC_STATS(sock_net(ssk),
 				MPTCP_MIB_DSSCORRUPTIONFALLBACK);
 		mptcp_do_fallback(ssk);