Skip to content
This repository has been archived by the owner on Mar 28, 2018. It is now read-only.

Commit

Permalink
CI: Perform basic checks on PR commits.
Browse files Browse the repository at this point in the history
Use the new "checkcommits" program in the "tests" repository
to perform basic checks on PR commits, such as:

- Subject
  - Contains a subsystem.
  - Length is within prescribed limits.

- Body
  - Contains a "Fixes #XXX" comment.
  - Line lengths are within prescribed limits.

Unlike the original implementation (#873), "checkcommits" should
be more robust.

Fixes #872.

Signed-off-by: James O. D. Hunt <[email protected]>
  • Loading branch information
jodh-intel committed Jun 7, 2017
1 parent 086fa29 commit cc7ece4
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
34 changes: 34 additions & 0 deletions .ci/ci-pre-checks.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#!/bin/bash
# This file is part of cc-oci-runtime.
#
# Copyright (C) 2017 Intel Corporation
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

#---------------------------------------------------------------------
# Description: Perform basic checks on the branch before attempting
# to run the build and test suites. If this script fails, the CI run
# will be aborted.
#---------------------------------------------------------------------

repo="github.com/clearcontainers/tests/cmd/checkcommits"
go get -d "$repo"
(cd "$GOPATH/src/$repo" && make)
checkcommits \
--need-fixes \
--need-sign-offs \
--body-length 72 \
--subject-length 75 \
--verbose
4 changes: 4 additions & 0 deletions .ci/ci-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ set -e -x
root=$(cd `dirname "$0"`/..; pwd -P)
source "$root/versions.txt"

# Run checks on commit meta-data before attempting to run the build
# and test phases.
$(dirname "$0")/ci-pre-checks.sh

if [ "$SEMAPHORE" = true ]
then
# SemaphoreCI has different environments that builds can run in. The
Expand Down

0 comments on commit cc7ece4

Please sign in to comment.