Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add document for AI models security enhancement #154

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

dongx1x
Copy link
Contributor

@dongx1x dongx1x commented Sep 17, 2023

No description provided.

@leyao-daily
Copy link

Maybe we also add some refer link to this markdown page in README?

@dongx1x
Copy link
Contributor Author

dongx1x commented Sep 18, 2023

Maybe we also add some refer link to this markdown page in README?

yes, let's review the content and title first.

docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
- Register key to Key Broker Service (KBS), and KBS communicates with key management service (KMS) to store the key.


### 1.2 Confidential Cloud Native Primitives (CCNP)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud-Native

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this document, seems to be CNCF style to not use hyphen:
https://github.com/cncf/foundation/blob/main/style-guide.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hwang37 what are your suggestions on this? Cloud Native or Cloud-Native?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember Hongbo mentioned it is some hyphen added by legal. So it will be our official name.

docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved

### 2.1 Mode Encryption

AES GCM is a widely used encryption algorithm and mode of operation for securing data, particularly in network communications and data storage. It combines two important cryptographic techniques: AES and GCM. AES is a symmetric encryption algorithm that uses a shared secret key for both encryption and decryption. GCM is based on a combination of CTR and GMAC, this combination ensures that not only is the data encrypted, but it also includes an authentication tag that allows the recipient to verify the integrity of the data.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AES-GCM is a widely used block cipher mode of operation ....
And regarding the introduction of GCM, i remember it is an algorithm that runs on a block cipher with block size 128 bits(mainly AES). And GMAC is the authentication-only variant of GCM. Please take the NIST publication as reference. https://nvlpubs.nist.gov/nistpubs/legacy/sp/nistspecialpublication800-38d.pdf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GMAC is the authentication-only variant of GCM, and GCM is based on a combination of CTR and GMAC, this should be ok, right?

docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
@dongx1x dongx1x force-pushed the model-doc branch 2 times, most recently from dd6c133 to 387bda6 Compare September 25, 2023 01:38
README.md Show resolved Hide resolved
- Register key to Key Broker Service (KBS), and KBS communicates with key management service (KMS) to store the key.


### 1.2 Confidential Cloud Native Primitives (CCNP)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this document, seems to be CNCF style to not use hyphen:
https://github.com/cncf/foundation/blob/main/style-guide.md

docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
docs/Security_Enhancement_For_AI_Models.md Outdated Show resolved Hide resolved
@dongx1x dongx1x force-pushed the model-doc branch 5 times, most recently from d13c84e to 6452b00 Compare September 25, 2023 07:53
@hwang37
Copy link
Contributor

hwang37 commented Sep 25, 2023

LGTM

Copy link
Contributor

@hwang37 hwang37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@leyao-daily leyao-daily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@Hulongyin Hulongyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@dongx1x dongx1x merged commit 58cafec into intel:main Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants