Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: easy tool to quick setup the cluster from zero #163

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

leyao-daily
Copy link

This PR introduces an orchestrated procedure to setup a host machine and initialize or join a Kubernetes cluster. The script is designed to ensure host readiness, disable swap, configure kernel parameters, install necessary prerequisites like Docker and Kubernetes packages, setup Containerd, initialize or join the cluster, and optionally setup a Container Network Interface (CNI) plugin.

@leyao-daily leyao-daily added the enhancement New feature or request label Oct 24, 2023
@leyao-daily leyao-daily self-assigned this Oct 24, 2023
@jiere
Copy link

jiere commented Oct 24, 2023

May I know why use Python to organize such scripts? Since we have "tools" directory also in this repo which hosts shell scripts there.

@leyao-daily
Copy link
Author

May I know why use Python to organize such scripts? Since we have "tools" directory also in this repo which hosts shell scripts there.

Tools for the cnap related shell scripts, and this is used to setup k8s quick on a new setup machine, so i just move it to k8s-mainifests, one can execute it to setup or join cluster quick, especially for some testing or demo.

Using python can brings more feature and flexiblities to it. Maybe cross platform bulabula..

Of course, if we don't need this to setup k8s, i can move it to other repo or location. :)

@jiere
Copy link

jiere commented Oct 25, 2023

Using python can brings more feature and flexiblities to it. Maybe cross platform bulabula..

Of course, if we don't need this to setup k8s, i can move it to other repo or location. :)

Yeah, what I am thinking is just about where to put such deployment related scripts, since our current demo repo is not really open sourced in public, but for real open source project, deployment related scripts are usually in Shell/Ansible/helm(yaml), etc.

@leyao-daily
Copy link
Author

Using python can brings more feature and flexiblities to it. Maybe cross platform bulabula..
Of course, if we don't need this to setup k8s, i can move it to other repo or location. :)

Yeah, what I am thinking is just about where to put such deployment related scripts, since our current demo repo is not really open sourced in public, but for real open source project, deployment related scripts are usually in Shell/Ansible/helm(yaml), etc.

what do yout think a directoryutilities or dependencies, because k8s is indeed the dependency of the project?

README.md Outdated Show resolved Hide resolved
Copy link

@jiere jiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current directory LGTM.
Since we have involved KEDA/Kepler in this project scope in README.md, I will raise PR to include the Kepler deployment later on top of your work:)
How about KEDA then? Maybe KEDA/Kepler scripts could be placed under tools/integration?

@leyao-daily
Copy link
Author

Current directory LGTM. Since we have involved KEDA/Kepler in this project scope in README.md, I will raise PR to include the Kepler deployment later on top of your work:) How about KEDA then? Maybe KEDA/Kepler scripts could be placed under tools/integration?

We have keda scable job for cnap yet, and for keda installation, we deliver the document under ./docs

Copy link
Contributor

@Hulongyin Hulongyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@leyao-daily leyao-daily merged commit 4711273 into intel:main Oct 27, 2023
2 checks passed
@leyao-daily leyao-daily deleted the k8s branch October 27, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants