Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.py: design and create the basic model info class #30

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

leyao-daily
Copy link

This PR is to fix #29 and it introduces three new classes: ModelInfo, ModelDetails, and ModelMetrics. These classes are designed to encapsulate all relevant information about an Inference model within a inference pipeline.

ModelMetrics holds the performance metrics of a inference learning model, such as accuracy, precision, recall, F1 score, and loss value. Each of these metrics can be accessed using their respective property methods.

ModelDetails encapsulates various details about the model, including the model's name, version, the framework used for training, the target, and the data type of the model.

ModelInfo ties all this information together, containing an instance of ModelDetails, the model's upload date, and an instance of ModelMetrics. Additionally, it includes a unique identifier for each model using Python's built-in uuid library.

@leyao-daily leyao-daily added the feature new feature development label Jul 4, 2023
@leyao-daily leyao-daily self-assigned this Jul 4, 2023
cnap/core/model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Hulongyin Hulongyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@leyao-daily leyao-daily merged commit 4bf00ae into intel:main Jul 5, 2023
@leyao-daily leyao-daily deleted the model branch July 5, 2023 07:58
@leyao-daily
Copy link
Author

Closes #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

design and create the model info base class
2 participants