Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change workflows to use ubuntu-22.04 instead of ubuntu-latest #2878

Closed
wants to merge 2 commits into from

Conversation

rudrakshkarpe
Copy link
Contributor

Fixes #2877

@rudrakshkarpe rudrakshkarpe changed the title ci: change workflows to use ubuntu-22.04 instead of ubuntu-latest (#2… ci: change workflows to use ubuntu-22.04 instead of ubuntu-latest (#2877) Mar 30, 2023
@rudrakshkarpe rudrakshkarpe changed the title ci: change workflows to use ubuntu-22.04 instead of ubuntu-latest (#2877) ci: change workflows to use ubuntu-22.04 instead of ubuntu-latest Mar 30, 2023
@terriko
Copy link
Contributor

terriko commented Apr 4, 2023

Since #2877 was claimed by someone else first, I've merged their pull request (#2879) and I'm going to close yours. But it does look correct, and if you needed a pull request for GSoC this still counts even though we couldn't merge the code. Thanks for giving it a shot!

@terriko terriko closed this Apr 4, 2023
@rudrakshkarpe
Copy link
Contributor Author

Since #2877 was claimed by someone else first, I've merged their pull request (#2879) and I'm going to close yours. But it does look correct, and if you needed a pull request for GSoC this still counts even though we couldn't merge the code. Thanks for giving it a shot!

It's true tho if you could notice I reacted to the issue even before it was claimed. And my PR was raised first. It's my mistake, I understand, I should have claimed the issue where I just tried to follow some of your mentions in the issues discussion where I came across you believe in work rather than claiming issues. TBH it was a pretty good learning experience. Next time, I'll make sure to claim or mention it before I start working.

Thank you for considering it for GSoC'23, I'm on my way to contributing ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: change linters to use specific ubuntu instead of unbuntu-latest
2 participants