Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mismatch_loader #4245

Merged
merged 4 commits into from
Jul 8, 2024
Merged

docs: mismatch_loader #4245

merged 4 commits into from
Jul 8, 2024

Conversation

inosmeet
Copy link
Contributor

@inosmeet inosmeet commented Jul 6, 2024

No description provided.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this, I'm wondering if we might need to change the directory name from "data" because I feel like users might think that means something more like the cache and could include, say, NVD and OSV data. We could probably make it more clear somewhow.

I don't want to try to come up with a better name right now because I'd like to get some stuff merged so you can move forwards, but think about what you want to call it when we (hopefully) have it as a separately-usable component? We're not going to call it "data" then. We could make it match purl2cpe but we're like... purl2invalidvendor which doens't quite roll of the tongue. purl2mismatch? Not sure. I'll let you think about it and we can refactor later.

@terriko terriko merged commit 055324b into intel:main Jul 8, 2024
22 checks passed
@inosmeet inosmeet deleted the docs branch July 19, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants