-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed metric ids in cvedb to constants (#4473) #4475
Conversation
There's no obvious reason for the test failures (it looks like they just aborted silently for some reason?) so I'm going to go ahead and re-run the failing tests. |
@terriko my pre-commit hook went through with all the linting, don't know why the action failed. |
ab4b89e
to
e21e691
Compare
Oh I missed the test. I removed now the EPSS_finder from the test |
Looks like I got most of the tests behaving again, but unfortunately the long tests are timing out and the repo is set up to not let me merge unless they pass. I don't think it's your fault: it looks like for some reason the regular scanner tests are taking considerably longer than usual. Just wanted to let you know that I'm looking into it, and I'll probably try re-running the tests at least once more at the end of my work day. |
Okay, thanks for the info. |
Quick heads up: I think I've fixed the longtests in #4509 but everything hasn't finished running and I'm waiting on another change to the required test rules, so this might not pass as expected. But I'm still working on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray, it's merge time! Thank you again for finding this, working out a solution, and your incredible patience while I fought with our CI system.
Introduced constants for metric_ids in cvedb to remove need for cursor argument in
epss_source.py
. This fixes the bug of "missing 1 required positional argument" while fetching epss data.