fix espi_hub: remove repeated data send in peripheral callback #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix ensures that the peripheral notification event is only triggered once in the callback function. Previously, each call to espi_add_callback would insert the into a linked list. This list would then be searched, and all matching ESPI_BUS_PERIPHERAL_NOTIFICATION events would be invoked when calling the callbacks.
yimjiajun
requested review from
albertofloyd,
VenkatKotakonda,
kashah1 and
rgundi
as code owners
albertofloyd
approved these changes
Sep 4, 2024
|
@yimjiajun thanks for your contribution and patience. However, the kbchost workaround removal will be slightly different since needs to be reworked to discriminate against when callback event corresponds to HOST_KBC_EVT_IBF in some EC vendor driver implementations. fyi @Asthachavda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix ensures that the peripheral notification event is only triggered once in the callback function.
Previously, each call to espi_add_callback would insert the into a linked list.
This list would then be searched, and all matching ESPI_BUS_PERIPHERAL_NOTIFICATION events would be invoked when calling the callbacks.