Add XeTLA FA backward implementation to benchmark
#2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESI-SYD
requested review from
anmyachev,
whitneywhtsang,
etiotto and
chengjunlu
chengjunlu
approved these changes
Sep 27, 2024
ESI-SYD
force-pushed
the
yudong/fa_bwd_xetla
branch
from
d38497e
to
1b1064c
Compare
anmyachev
reviewed
Sep 29, 2024
Co-authored-by: Anatoly Myachev <[email protected]>
chengjunlu
approved these changes
Oct 8, 2024
CI tutorial seems not ready for backward (include torch's implication) yet. |
ZzEeKkAa
reviewed
Oct 8, 2024
| set(XETLA_KERNEL_FLAGS ${XETLA_KERNEL_FLAGS} -fsycl) | ||
| set(XETLA_KERNEL_FLAGS ${XETLA_KERNEL_FLAGS} | ||
| -fsycl | ||
| -fsycl-device-code-split=per_kernel |
There was a problem hiding this comment.
This change adds additional flag to perform sycl kernel splitting and helps to resolve RuntimeError below.
No perf regression for xetla in my local env.
RuntimeError: The program was built for 1 devices
Build program log for 'Intel(R) Data Center GPU Max 1100':
-11 (PI_ERROR_BUILD_PROGRAM_FAILURE)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation comes from IPEX
https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11089057652