Replace TritonGEN barrier with spirv::ControlBarrierOp #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMarno
commented
Oct 9, 2024
test/Conversion/intel/tritongpu_to_llvm_intel_advanced_path.mlir
Outdated
Show resolved
Hide resolved
FMarno
force-pushed
the
finlay/poc_spirv_barrier
branch
from
995c3b8
to
9b9dbde
Compare
FMarno
force-pushed
the
finlay/poc_spirv_barrier
branch
from
26a77f8
to
b70d87c
Compare
FMarno
force-pushed
the
finlay/poc_spirv_barrier
branch
from
b70d87c
to
ce93380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for the adoption of
spirv::ControlBarrierOpin place ofTritonGEN::Barrier. Right now I'm looking for opinions of if this is an acceptable route.You can read about the semantics here: https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#OpControlBarrier.