erasure_code: constify a bunch of "src" args #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
force-pushed
the
constify_ec_encode_data
branch
6 times, most recently
from
ff48ec9
to
708181d
Compare
The reasoning for this commit is to constify ec_encode_data() function. It is expected that after this function has run, the data that "src" argument points to has not changed. Hence this argument should really be `const`. All other functions that undergo same changes here are simply called by ec_encode_data() internally, one way or another. Signed-off-by: Konstantin Kharlamov <[email protected]>
Hi-Angel
force-pushed
the
constify_ec_encode_data
branch
from
708181d
to
c500af5
Compare
|
Okay, I fixed various build errors that CI noticed, which weren't reproducible on my system (various macros compile or not, depending on configuration), now it passes. |
|
Oh, I noticed there're warnings in CI build in a similar vein that are missing on my system. Okay, before I move on to fixing them, I'd like to hear some opinion from maintainers on the changes. |
|
Thanks but I don't think we want to change the interface at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning for this commit is to constify ec_encode_data() function.
It is expected that after this function has run, the data that "src"
argument points to has not changed. Hence this argument should really be
const.All other functions that undergo same changes here are simply called by
ec_encode_data() internally, one way or another.
Signed-off-by: Konstantin Kharlamov [email protected]