Add Android.bp for libva 2.22 #835
Conversation
Tried to generate the va/va_version.h from Android.bp but met with some road blocks. So for the time being added the pre-generated va_version.h |
|
I still hope we could generate va/va_version.h from android.bp, then the behavior will be aligned between linux/win/android. @rosetta-jpn any comments? |
* Add Android.bp to replace mk files * Add va_version.h for external reference Tracked-On: OAM-117146 Signed-off-by: zhangyichix <[email protected]>
JeevakaPrabu
force-pushed
the
android_bp
branch
6 times, most recently
from
4ae534d
to
36836b6
Compare
JeevakaPrabu
force-pushed
the
android_bp
branch
from
36836b6
to
d0a1c1e
Compare
Android.bp
Outdated
| ], | ||
|
|
||
| local_include_dirs: [ | ||
| ".", |
There was a problem hiding this comment.
The "." include doesn't seem necessary. I tested locally and libva still builds without it.
Android.bp
Outdated
| cc_library_shared { | ||
| name: "libva-android", | ||
|
|
||
| static_libs: [ |
There was a problem hiding this comment.
It looks like you can remove this entire static_libs.
Android.bp
Outdated
| cflags: [ | ||
| "-Wall", | ||
| "-Werror", | ||
| "-Wno-error", |
There was a problem hiding this comment.
This seems like it would cancel out the effect to -Werror.
JeevakaPrabu
force-pushed
the
android_bp
branch
from
d0a1c1e
to
85560aa
Compare
| "va/drm/va_drm_utils.c", | ||
| ], | ||
|
|
||
| cflags: [ |
There was a problem hiding this comment.
Some questions/comments to maybe simplify these flags:
"-D_FILE_OFFSET_BITS=64": isn't this implied by the fact that this module is only enabled onx86_64? According to this: "On 64 bit systems this macro has no effect since the *64 functions are identical to the normal functions."-Wall: this can be removed because it's globally enabled. See this.-O2: this is also globally enabled. See this.-fPIC: the fact that this is a shared library module should imply position-independent code. See also this.-DANDROID: this can be removed because it's globally enabled. See this.
Additionally, you had -Werror before. Consider adding that back.
There was a problem hiding this comment.
Recommended change done
|
|
||
| arch: { | ||
| x86_64: { | ||
| cflags: ["-DVA_DRIVERS_PATH=\"/vendor/lib64\""], |
| "va/drm/va_drm_utils.c", | ||
| ], | ||
|
|
||
| cflags: [ |
There was a problem hiding this comment.
Same comments as above about the flags.
Changes include: - Updated Android.bp to add license package and enable it only for x86_64 - Added genrule to generate the va_version.h. - Removed va_version.h Signed-off-by: JeevakaPrabu <[email protected]> Signed-off-by: Andreas Huber <[email protected]>
JeevakaPrabu
force-pushed
the
android_bp
branch
from
85560aa
to
fce7b82
Compare
Changes include: